Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EIP-7377: Fix some nits #7419

Merged
merged 4 commits into from
Jul 27, 2023
Merged

Update EIP-7377: Fix some nits #7419

merged 4 commits into from
Jul 27, 2023

Conversation

jtraglia
Copy link
Member

@jtraglia jtraglia commented Jul 27, 2023 •
edited
Loading

While reading this EIP, I noticed a few mistakes I would like to fix:

  • Minor typo in sentence.
  • Minor table formatting issue.
  • Unnecessary comma in sentence.
  • storageTuples should be storage to match table of fields.
  • An "it's" v.s. "its" problem.
  • A duplicate word in "migration transaction transaction."
  • I think "MigrationTransaction" should be "migration transaction."

By the way, the transaction type format in the abstract uses storage instead of storageTuples too:

EIPs/EIPS/eip-7377.md

Line 16 in bf74be7

Introduce a new [EIP-2718](./eip-2718.md) transaction type with the format `0x04 || rlp([chainId, nonce, maxFeePerGas, maxPriorityFeePerGas, gasLimit, codeAddr, storage, data, value, accessList, yParity, r, s])` which sets the sending account's `code` field in the state trie to the `code` value at `codeAddr` and applies the storage tuples to the sender's storage trie.

@jtraglia jtraglia requested a review from eth-bot as a code owner July 27, 2023 18:17
@github-actions github-actions bot added c-update Modifies an existing proposal s-draft This EIP is a Draft t-core labels Jul 27, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Jul 27, 2023 •
edited
Loading

✅ All reviewers have approved.

@eth-bot eth-bot changed the title Fix some nits in EIP-7377 Update EIP-7377: Fix some nits in EIP-7377 Jul 27, 2023
@eth-bot eth-bot added the a-review Waiting on author to review label Jul 27, 2023
@jtraglia jtraglia changed the title Update EIP-7377: Fix some nits in EIP-7377 Update EIP-7377: Fix some nits Jul 27, 2023
lightclient
lightclient approved these changes Jul 27, 2023
View reviewed changes
Copy link
Member

@lightclient lightclient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing thank you sir

@eth-bot eth-bot enabled auto-merge (squash) July 27, 2023 23:50
eth-bot
eth-bot approved these changes Jul 27, 2023
View reviewed changes
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit 3d9fea5 into ethereum:master Jul 27, 2023
@jtraglia jtraglia deleted the patch-1 branch July 28, 2023 00:58
This was referenced Aug 31, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eth-bot eth-bot eth-bot approved these changes

@lightclient lightclient lightclient approved these changes

Assignees
No one assigned
Labels
a-review Waiting on author to review c-update Modifies an existing proposal s-draft This EIP is a Draft t-core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jtraglia @eth-bot @lightclient